Etherscan V2 workaround #2679
Merged
Etherscan V2 workaround #2679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sparrowDom
requested review from
clement-ux,
naddison36 and
shahthepro
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2679 +/- ##
=======================================
Coverage 35.37% 35.37%
=======================================
Files 112 112
Lines 5331 5331
Branches 1412 1412
=======================================
Hits 1886 1886
Misses 3444 3444
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shahthepro
reviewed
Oct 6, 2025
shahthepro
approved these changes
Oct 6, 2025
naddison36
previously approved these changes
Oct 7, 2025
| ``` | ||
| npx hardhat --network mainnet verify --contract contracts/vault/VaultAdmin.sol:VaultAdmin 0x31a91336414d3B955E494E7d485a6B06b55FC8fB | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Can we add an example with a constructor parameter. This one is from the deployment template in Notion
echo "module.exports = [{
platformAddress: \"0x0000000000000000000000000000000000000001\",
vaultAddress: \"0xe75d77b1865ae93c7eaa3040b038d7aa7bc02f70\",
}]" > flux-args.js
npx hardhat --network mainnet verify --contract contracts/strategies/FluxStrategy.sol:FluxStrategy --constructor-args flux-args.js 0x57d49c28Cf9A0f65B1279a97eD01C3e49a5A173f
There was a problem hiding this comment.
good point thanks added here: https://github.com/OriginProtocol/origin-dollar/pull/2679/commits
shahthepro
previously approved these changes
Oct 9, 2025
sparrowDom
dismissed stale reviews from naddison36 and shahthepro
via
279bfaa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Etherscan has migrated to V2 api for the contract verification. There are guides on how to migrate, but I couldn't get a workable combination of packages. Increasing some of the versions also introduces great breaking changes.
This PR finds a workaround on how to verify contracts by forcing a V2 api with the necessary
chainIdget parameter without any changes to the installed packages